[libcxx-commits] [PATCH] D149635: [libunwind] include alloca.h in config.h

Alexander Richardson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon May 8 23:13:11 PDT 2023


arichardson added inline comments.


================
Comment at: libunwind/src/config.h:16
 
+#include <alloca.h>
 #include <assert.h>
----------------
compnerd wrote:
> mstorsjo wrote:
> > compnerd wrote:
> > > Is this available on MSVC?
> > It's not, as already commented above - it's not available in either MSVC or mingw toolchains.
> Should this be something that we put into a configuration then?  Or provide shims for?
Could we avoid the header and just use __builtin_alloca? Or is that code path used with compilers that don't support this built-in?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149635/new/

https://reviews.llvm.org/D149635



More information about the libcxx-commits mailing list