[libcxx-commits] [libcxx] 7ad7b32 - [AIX] Adjust support of format function tests

Jake Egan via libcxx-commits libcxx-commits at lists.llvm.org
Mon May 8 10:41:09 PDT 2023


Author: Jake Egan
Date: 2023-05-08T13:41:00-04:00
New Revision: 7ad7b3275f702128ee49883c17f8e3c19e9ad450

URL: https://github.com/llvm/llvm-project/commit/7ad7b3275f702128ee49883c17f8e3c19e9ad450
DIFF: https://github.com/llvm/llvm-project/commit/7ad7b3275f702128ee49883c17f8e3c19e9ad450.diff

LOG: [AIX] Adjust support of format function tests

escaped_output.unicode.pass.cpp is failing only on 32-bit AIX. The rest are passing.

Reviewed by: #libc, Mordante

Differential Revision: https://reviews.llvm.org/D149078

Added: 
    

Modified: 
    libcxx/test/std/utilities/format/format.functions/escaped_output.unicode.pass.cpp
    libcxx/test/std/utilities/format/format.functions/unicode.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/std/utilities/format/format.functions/escaped_output.unicode.pass.cpp b/libcxx/test/std/utilities/format/format.functions/escaped_output.unicode.pass.cpp
index 8ee7396871f29..5d838a727bf5e 100644
--- a/libcxx/test/std/utilities/format/format.functions/escaped_output.unicode.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.functions/escaped_output.unicode.pass.cpp
@@ -11,9 +11,8 @@
 // This version runs the test when the platform has Unicode support.
 // UNSUPPORTED: libcpp-has-no-unicode
 
-// TODO FMT Investigate Windows and AIX issues.
-// UNSUPPORTED: msvc, target={{.+}}-windows-gnu
-// UNSUPPORTED: LIBCXX-AIX-FIXME
+// TODO FMT Investigate Windows and 32-bit AIX issues.
+// UNSUPPORTED: msvc, target={{.+}}-windows-gnu, target=powerpc-ibm-aix{{.*}}
 
 // TODO FMT Fix this test using GCC, it currently crashes.
 // UNSUPPORTED: gcc-12

diff  --git a/libcxx/test/std/utilities/format/format.functions/unicode.pass.cpp b/libcxx/test/std/utilities/format/format.functions/unicode.pass.cpp
index 1af442ea4d65a..c90e5c2fc1c49 100644
--- a/libcxx/test/std/utilities/format/format.functions/unicode.pass.cpp
+++ b/libcxx/test/std/utilities/format/format.functions/unicode.pass.cpp
@@ -11,9 +11,8 @@
 // This version runs the test when the platform has Unicode support.
 // UNSUPPORTED: libcpp-has-no-unicode
 
-// TODO FMT Investigate Windows and AIX issues.
+// TODO FMT Investigate Windows issues.
 // UNSUPPORTED msvc, target={{.+}}-windows-gnu
-// UNSUPPORTED: LIBCXX-AIX-FIXME
 
 // TODO FMT This test should not require std::to_chars(floating-point)
 // XFAIL: availability-fp_to_chars-missing


        


More information about the libcxx-commits mailing list