[libcxx-commits] [libcxx] efd0b42 - [libc++][AIX] Remove LIBCXX-AIX-FIXME feature from test

Jake Egan via libcxx-commits libcxx-commits at lists.llvm.org
Mon May 8 07:53:53 PDT 2023


Author: Jake Egan
Date: 2023-05-08T10:53:45-04:00
New Revision: efd0b42171e9b3536d02becbbf3738ded2adbcb3

URL: https://github.com/llvm/llvm-project/commit/efd0b42171e9b3536d02becbbf3738ded2adbcb3
DIFF: https://github.com/llvm/llvm-project/commit/efd0b42171e9b3536d02becbbf3738ded2adbcb3.diff

LOG: [libc++][AIX] Remove LIBCXX-AIX-FIXME feature from test

This test was originally unsupported for `LIBCXX-AIX-FIXME` feature because we lacked `-fvisibility=hidden` support. AIX now has visibility support and the test passes in debug mode.

Reviewed By: #libc, Mordante

Differential Revision: https://reviews.llvm.org/D149255

Added: 
    

Modified: 
    libcxx/test/libcxx/debug/extern-templates.sh.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/libcxx/debug/extern-templates.sh.cpp b/libcxx/test/libcxx/debug/extern-templates.sh.cpp
index 612da5e0f0f1..2c4191eec2d6 100644
--- a/libcxx/test/libcxx/debug/extern-templates.sh.cpp
+++ b/libcxx/test/libcxx/debug/extern-templates.sh.cpp
@@ -21,8 +21,6 @@
 // option which clang doesn't accept on Windows.)
 // UNSUPPORTED: windows
 
-// XFAIL: LIBCXX-AIX-FIXME
-
 // RUN: %{cxx} %{flags} %{compile_flags} %s %{link_flags} -fPIC -DTU1 -fvisibility=hidden -shared -o %t.lib
 // RUN: cd %T && %{cxx} %{flags} %{compile_flags} %s ./%basename_t.tmp.lib %{link_flags} -DTU2 -fvisibility=hidden -o %t.exe
 // RUN: %{exec} %t.exe


        


More information about the libcxx-commits mailing list