[libcxx-commits] [PATCH] D149078: [AIX] Adjust support of format function tests

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

I'm still happy with this patch.

In D149078#4309657 <https://reviews.llvm.org/D149078#4309657>, @Jake-Egan wrote:

>> Since I don't have access to a system with a 16-bit wchar_t it would be great if you could look at fixing the tests too.
>
> @mordante The test fails at the `assert(false);` line after calling `test_ill_formed_utf16()`. I haven't looked into the test in depth, so forgive me if it's obvious, but the other functions `test_ill_formed_utf8()` and `test_ill_formed_utf32()` don't assert false, so it looks like this was a mistake.

At some point I will look into this. The main issue is that the CI doesn't give nice output when things fails for wide strings. I probably write an wide to narrow string transcoder so the CI has readable output. (But this is a bit low on my priority list.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149078/new/

https://reviews.llvm.org/D149078