[libcxx-commits] [PATCH] D150056: [libc++] test/libcxx/transitive_includes.sh.cpp dumps loads of unhelpful preprocessor output when it fails

[Ian Anderson via Phabricator via libcxx-commits]

iana added inline comments.


================
Comment at: libcxx/test/libcxx/transitive_includes.sh.cpp:60
   normalized_header = re.sub('/', '_', header)
-  print(f"// {RUN}: %{{cxx}} %s %{{flags}} %{{compile_flags}} --trace-includes -fshow-skipped-includes --preprocess -DTEST_{i} 2> %t/header.{normalized_header}")
+  print(f"// {RUN}: %{{cxx}} %s %{{flags}} %{{compile_flags}} --trace-includes -fshow-skipped-includes --preprocess -DTEST_{i} > /dev/null 2> %t/header.{normalized_header}")
   print(f"#if defined(TEST_{i})")
----------------
This is the only actual changed line, the rest of them were done by `libcxx-generate-files`. We could also do `>&-` to close stdout, but the internet suggests that's a bit spotty. Although it does work for at least clang, if people prefer that method.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150056/new/

https://reviews.llvm.org/D150056