[libcxx-commits] [PATCH] D150055: [libc++][Modules] Add missing includes and exports

Ian Anderson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat May 6 17:45:57 PDT 2023


iana created this revision.
iana added reviewers: ldionne, Bigcheese, Mordante, philnik.
Herald added a subscriber: ributzka.
Herald added a project: All.
iana requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Several headers are missing includes for things they use.

type_traits.is_enum needs to export type_traits.integral_constant so that clients can access its `value` member without explicitly including __type_traits/integral_constant.h themselves.

Make `subrange_fwd` a peer submodule to `subrange` rather than a submodule of it, and have `subrange` export `subrange_fwd`. That will make it easier to programmatically generate modules for the private detail headers, and it will accomplish the same effect that __ranges/subrange.h will make subrange_kind visible.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D150055

Files:
  libcxx/include/__algorithm/ranges_minmax.h
  libcxx/include/__algorithm/ranges_partition_copy.h
  libcxx/include/__format/format_arg.h
  libcxx/include/__functional/bind.h
  libcxx/include/__functional/bind_back.h
  libcxx/include/__functional/bind_front.h
  libcxx/include/__functional/boyer_moore_searcher.h
  libcxx/include/__functional/compose.h
  libcxx/include/__functional/function.h
  libcxx/include/__functional/not_fn.h
  libcxx/include/__hash_table
  libcxx/include/__locale
  libcxx/include/__ranges/copyable_box.h
  libcxx/include/__ranges/filter_view.h
  libcxx/include/__ranges/join_view.h
  libcxx/include/__ranges/range_adaptor.h
  libcxx/include/__ranges/transform_view.h
  libcxx/include/__ranges/zip_view.h
  libcxx/include/__tree
  libcxx/include/module.modulemap.in
  libcxx/include/optional
  libcxx/include/string_view
  libcxx/include/tuple
  libcxx/include/unordered_map
  libcxx/test/libcxx/transitive_includes.sh.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150055.520132.patch
Type: text/x-patch
Size: 55123 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230507/3846554e/attachment-0001.bin>


More information about the libcxx-commits mailing list