[libcxx-commits] [PATCH] D148499: [libunwind] Unwind through Linux riscv64 sigreturn frame

Fangrui Song via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat May 6 11:12:13 PDT 2023


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: libunwind/src/UnwindCursor.hpp:2843
+  // A signal frame will have a return address pointing to
+  // __vdso_rt_sigteturn. This code is hardwired as:
+  //
----------------
This is `__vdso_rt_sigreturn`, not `__vdso_rt_sigteturn`. I'll fix it.

The canonical term is `sigreturn trampoline` (used the most in the Linux kernel), not signal frame.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148499/new/

https://reviews.llvm.org/D148499



More information about the libcxx-commits mailing list