[libcxx-commits] [PATCH] D149868: [libc++][format][chrono] Fix incorrect subsecond part of `duration` in format string "%S"

[Mark de Wever via Phabricator via libcxx-commits]

Mordante requested changes to this revision.
Mordante added a comment.
This revision now requires changes to proceed.

Thanks for working on this! For your next upload can you either use the arc tool or a diff with a high context. That way it's easier to review the patch in context.

Can you also add tests for this change, for example the ones in the bug report. (I think using microseconds does not give the proper resolution, but that's easier to validate with tests and the CI.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149868/new/

https://reviews.llvm.org/D149868