[libcxx-commits] [PATCH] D142335: [libc++][ranges] Implement `ranges::to`.
Konstantin Varlamov via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu May 4 16:25:13 PDT 2023
var-const marked 2 inline comments as done.
var-const added inline comments.
================
Comment at: libcxx/include/deque:970
+ template <class _Iterator, class _Sentinel>
+ _LIBCPP_HIDE_FROM_ABI
----------------
philnik wrote:
> Why not `_Iter` and `_Sent` like we use elsewhere?
I find it impossible to be consistent here because the existing code is inconsistent (across different headers, at the very least), so I just went with my personal preference. I find abbreviations a necessary evil when dealing with numerous template parameters but avoid them when possible.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142335/new/
https://reviews.llvm.org/D142335
More information about the libcxx-commits
mailing list