[libcxx-commits] [PATCH] D132092: [2a/3][ASan][libcxx] std::deque annotations

Tacet via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 3 19:42:18 PDT 2023


AdvenamTacet added inline comments.


================
Comment at: libcxx/include/deque:903
+        typename __map::const_iterator __annotations_beg_mp = __map_.begin() + __beg / __block_size;
+        typename __map::const_iterator __annotations_end_mp = __map_.begin() + __end / __block_size;
+
----------------
philnik wrote:
> AdvenamTacet wrote:
> > philnik wrote:
> > > What does the `mp` stand for?
> > I believe `map_pointer`, but I used this name based on the rest of the code where it's used.
> Let's drop it if nobody knows what it actually stands for.
I changed it to `map`, I feel that it makes code much easier to read when it is clear if it points on the map (buffer of buffers) or the actual buffer. Hope it's clear now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132092/new/

https://reviews.llvm.org/D132092



More information about the libcxx-commits mailing list