[libcxx-commits] [PATCH] D149543: [libc++][format] Fixes vector<bool> requirements.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM but I think we should probably remove the header workaround.



================
Comment at: libcxx/include/vector:325
 
+// TODO FMT Make these normal includes after transitive includes are
+// removed from older language versions.
----------------
Which ones would we need to remove in order not to have this workaround? I think it might be reasonable to take the hit -- usually our stance is that we try not to remove transitive includes just for the sake of it, however when those transitive includes are a blocker to our work, we remove them. So IMO it would be reasonable to remove the transitive includes causing problems here, unless the impact is really too big.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149543/new/

https://reviews.llvm.org/D149543