[libcxx-commits] [PATCH] D149706: [libc++][PSTL] Implement std::copy{, _n}

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/__algorithm/pstl_copy.h:28
+
+// TODO: Use the std::copy/move shenanigans to forward to std::memmove
+
----------------
I think it's fine to do in a separate patch. However, I think we need to do this before we can figure out the backend story because that's definitely an additional complexity we'll want to take into account in our dispatching mechanism.


================
Comment at: libcxx/include/__algorithm/pstl_copy.h:34
+          enable_if_t<is_execution_policy_v<__remove_cvref_t<_ExecutionPolicy>>, int> = 0>
+_LIBCPP_HIDE_FROM_ABI _ForwardIterator2
+copy(_ExecutionPolicy&& __policy, _ForwardIterator1 __first, _ForwardIterator1 __last, _ForwardIterator2 __result) {
----------------
Let's do this consistently.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149706/new/

https://reviews.llvm.org/D149706