[libcxx-commits] [PATCH] D148753: [libcxx] move abi symbol checker logic to generic location

[Michael Francis via Phabricator via libcxx-commits]

francii added a comment.

@ldionne I'd also like your input on how to handle the current `generate-cxx-abilist` target.

The current abi check works by calling this function:

  function check-abi-list() {
      echo "+++ Running the libc++ ABI list test"
      ${NINJA} -vC "${BUILD_DIR}" check-cxx-abilist || (
          echo "+++ Generating the libc++ ABI list after failed check"
          ${NINJA} -vC "${BUILD_DIR}" generate-cxx-abilist
          false
      )
  }

My understanding is, currently, we only generate the abi list after a failed abi check. Since we're removing the CMake target, we'll be removing this call as well, but as a result we cannot conditionally generate the abi list during the build (as we do currently). My ideas for alternatives are:

1. Alter the function to just call `generate-cxx-abilist`. The CMake target will be updated to first check if there is an existing `.abilist` file before generating a new one.
2. Remove this function entirely. If the lit test fails, the user can run the `generate_abi_list.py` file directly if they fail the test and want to break the ABI.
3. In the lit test, call `generate_abi_list.py` if the abi check fails. We would need to consider how to mark the lit test as failure if this is the case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148753/new/

https://reviews.llvm.org/D148753