[libcxx-commits] [PATCH] D149593: [libc++][ranges] Fixes as_rvalue's linkage.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks for the review!

In D149593#4309957 <https://reviews.llvm.org/D149593#4309957>, @philnik wrote:

> Maybe we could add a clang-tidy check to make sure all variables in the `std::ranges::__cpo` namespace are marked `inline`?

That would be an extremely narrow check. I don't think that's too useful, especially since several similar issues were found be module tests. This tests validates the declarations in the headers and compares them in the modules. This is a useful test by itself and catches this error too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149593/new/

https://reviews.llvm.org/D149593