[libcxx-commits] [PATCH] D149635: [libunwind] include alloca.h in config.h

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D149635#4311710 <https://reviews.llvm.org/D149635#4311710>, @barannikov88 wrote:

>> picolibc (possibly erroneously) only includes alloca.h from stdlib.h if STRICT_ANSI is not defined
>
> The header is non-standard. It is correct not to include it when using -std=c* (as opposed to -std=gnu*).
> If libunwind relies on it in public header files, it should be rectified.

Indeed. In particular, mingw toolchains don't have an `alloca.h` header - this should show up as failure from those jobs in CI.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149635/new/

https://reviews.llvm.org/D149635