[libcxx-commits] [PATCH] D132092: [2a/3][ASan][libcxx] std::deque annotations

[Tacet via Phabricator via libcxx-commits]

AdvenamTacet added inline comments.


================
Comment at: libcxx/include/deque:902
+        // NOTE: if __end % __block_size == 0, __annotations_end_mp points at the next block, which may not exist
+        typename __map::const_iterator __annotations_beg_mp = __map_.begin() + __beg / __block_size;
+        typename __map::const_iterator __annotations_end_mp = __map_.begin() + __end / __block_size;
----------------
philnik wrote:
> Maybe use `__map_const_pointer`?
I did try it at the beginning and there are type related issues. It's much cleaner that way than working around it.


================
Comment at: libcxx/include/deque:903
+        typename __map::const_iterator __annotations_beg_mp = __map_.begin() + __beg / __block_size;
+        typename __map::const_iterator __annotations_end_mp = __map_.begin() + __end / __block_size;
+
----------------
philnik wrote:
> What does the `mp` stand for?
I believe `map_pointer`, but I used this name based on the rest of the code where it's used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132092/new/

https://reviews.llvm.org/D132092