[libcxx-commits] [PATCH] D147356: Fixing conflicting macro definitions between curses.h and the standard library.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik requested changes to this revision.
philnik added a comment.
This revision now requires changes to proceed.

Please make sure the CI is green.



================
Comment at: libcxx/test/libcxx/nasty_macros.compile.pass.cpp:145-150
+// Test to make sure curses has no conflicting macros with the standard library
+#ifdef __has_include
+#  if __has_include(<curses.h>)
+#    include <curses.h>
+#  endif
+#endif
----------------
I think this should just be
```lang=c++
#ifndef erase
#. define erase NASTY_MACRO
#endif
```
to make sure we always push and pop properly.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147356/new/

https://reviews.llvm.org/D147356