[libcxx-commits] [PATCH] D149092: [libcxxabi] disable lib{std}c++ assertions

Nick Desaulniers via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon May 1 11:41:47 PDT 2023


nickdesaulniers added a comment.

In D149092#4310340 <https://reviews.llvm.org/D149092#4310340>, @philnik wrote:

> I also can't tell you what is the right thing to do here. I think @ldionne may want to take a look. I think it would make sense to move it into libc++abi, but that wouldn't work when not linking against it, so I'm not sure this is the right call.

For context, I'm trying to remove libcxxabi's StringView class and replace it with std::string_view.  If std::string_view comes from libcxx, then we have a circular dependency wrt libcxx asserts or methods that throw.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149092/new/

https://reviews.llvm.org/D149092



More information about the libcxx-commits mailing list