[libcxx-commits] [PATCH] D149502: [libc++][PSTL] Remove configurations flags

Mon May 1 11:05:26 PDT 2023

philnik added inline comments.

================
Comment at: libcxx/include/__pstl/internal/pstl_config.h:39-41
-#define _PSTL_PRAGMA_SIMD_SCAN(PRM)
-#define _PSTL_PRAGMA_SIMD_INCLUSIVE_SCAN(PRM)
-#define _PSTL_PRAGMA_SIMD_EXCLUSIVE_SCAN(PRM)
----------------
ldionne wrote:
> If those are supported by Clang/GCC, let's keep these annotations.
These seem to be supported. I kept the `#if` in the simplification patch.

================
Comment at: libcxx/include/__pstl/internal/pstl_config.h:53-54
-#define _PSTL_PRAGMA_SIMD_EARLYEXIT
-#define _PSTL_PRAGMA_SIMD_ORDERED_MONOTONIC(PRM)
-#define _PSTL_PRAGMA_SIMD_ORDERED_MONOTONIC_2ARGS(PRM1, PRM2)
-
----------------
ldionne wrote:
> Let's also check if those are supported. Basically, we should strive to retain as much semantic annotations as we can -- there's no good reason to remove them unless they are not supported by the compiler or they're wrong (but right now we must assume that everything in the original PSTL is correct unless proven otherwise).
This seems to be an intel extension.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149502/new/

https://reviews.llvm.org/D149502