[libcxx-commits] [PATCH] D146392: [libc++][spaceship] Implement `operator<=>` for `optional`

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D146392#4308372 <https://reviews.llvm.org/D146392#4308372>, @H-G-Hristov wrote:

> Thank you for the review. I think I have addressed your comment. I just don't get what's going on with the CI. I haven't seen a green build for over a week.

The santizers are known to be buggy at the moment. The others should work again.



================
Comment at: libcxx/include/optional:1431
 
+#else // _LIBCPP_STD_VER >= 20
+
----------------
Typically we use the same condition in the comments. I was confused you wanted to use `operator<=>` before C++20.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146392/new/

https://reviews.llvm.org/D146392