[libcxx-commits] [PATCH] D149540: [libc++][PSTL] Implement std::fill{, _n}

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon May 1 08:40:30 PDT 2023


ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/test/std/algorithms/alg.modifying.operations/alg.fill/pstl.fill.pass.cpp:41
+    }
+    { // check than an empty range works
+      int a[1] = {2};
----------------
here and below.


================
Comment at: libcxx/test/std/algorithms/alg.modifying.operations/alg.fill/pstl.fill_n.pass.cpp:16
+// template<class ExecutionPolicy, class ForwardIterator, class T>
+//   void fill(ExecutionPolicy&& exec,
+//             ForwardIterator first, ForwardIterator last, const T& value);
----------------
Wrong signature!


================
Comment at: libcxx/test/std/algorithms/alg.modifying.operations/alg.fill/pstl.fill_n.pass.cpp:41
+    }
+    { // check than an empty range works
+      int a[1] = {2};
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149540/new/

https://reviews.llvm.org/D149540



More information about the libcxx-commits mailing list