[libcxx-commits] [PATCH] D146062: Simplify multidimensional methods by flattening c-arrays before constructing elements

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik requested changes to this revision.
philnik added a comment.
This revision now requires changes to proceed.

Could you split this into two patches? One where you merge `fill_n` and `value_construct_n` and another one where you do the optimization. Also, please add a benchmark in `libcxx/benchmarks`.



================
Comment at: libcxx/include/__memory/uninitialized_algorithms.h:366-369
+template<class _Tp>
+struct _IsBoundedArray { static constexpr bool value = false; };
+template<class _Tp, int _Num>
+struct _IsBoundedArray<_Tp[_Num]> { static constexpr bool value = true; };
----------------
Why not `is_bounded_array`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146062/new/

https://reviews.llvm.org/D146062