[libcxx-commits] [PATCH] D147175: [clang] Add __is_trivially_equality_comparable

[Shafik Yaghmour via Phabricator via libcxx-commits]

shafik added inline comments.


================
Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:3315
           Builder.Alignment, Builder.Alignment, CharUnits::Zero(),
           Builder.PrimaryBase, false, Builder.SharedVBPtrBase,
+          Builder.EndsWithZeroSizedObject, Builder.LeadsWithZeroSizedBase, true,
----------------



================
Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:3316-3317
           Builder.PrimaryBase, false, Builder.SharedVBPtrBase,
-          Builder.EndsWithZeroSizedObject, Builder.LeadsWithZeroSizedBase,
-          Builder.Bases, Builder.VBases);
+          Builder.EndsWithZeroSizedObject, Builder.LeadsWithZeroSizedBase, true,
+          true, Builder.Bases, Builder.VBases);
     } else {
----------------
For [bugprone-argument-comment](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/argument-comment.html)


================
Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:3351
           EmptySubobjects.SizeOfLargestEmptySubobject, Builder.PrimaryBase,
-          Builder.PrimaryBaseIsVirtual, nullptr, false, false, Builder.Bases,
+          Builder.PrimaryBaseIsVirtual, nullptr, false, false,
+          Builder.HasInternalPadding, Builder.HasTailPadding, Builder.Bases,
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147175/new/

https://reviews.llvm.org/D147175