[libcxx-commits] [PATCH] D144739: [libc++][chrono] Add sys_time formatter.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/include/__chrono/convert_to_tm.h:102
+    } else
+      static_assert(sizeof(_ChronoT) == 0, "Add the missing clock specialization");
+  } else if constexpr (chrono::__is_duration<_ChronoT>::value) {
----------------
It would be nice to implement this code path for the clocks that we do implement in libc++ for LLVM 17, to avoid the library being inconsistent with the clocks that it provides.


================
Comment at: libcxx/include/__chrono/ostream.h:43
+template <class _CharT, class _Traits, class _Duration>
+_LIBCPP_HIDE_FROM_ABI _LIBCPP_AVAILABILITY_FORMAT basic_ostream<_CharT, _Traits>&
+operator<<(basic_ostream<_CharT, _Traits>& __os, const sys_time<_Duration> __tp) {
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144739/new/

https://reviews.llvm.org/D144739