[libcxx-commits] [PATCH] D144326: [libc++][format] Addresses LWG3720.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/test/std/utilities/format/format.string/format.string.std/lwg3720_arg_id_width_precision_allowed_types.pass.cpp:11-13
+// This test requires the dylib support introduced in D92214.
+// XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx10.{{.+}}
+// XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx11.{{.+}}
----------------
I think you want to remove these annotations, and if the back-deployment CI fails, then you must be using floating-point to_chars, so you can add:

```
// XFAIL: availability-fp_to_chars-missing
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144326/new/

https://reviews.llvm.org/D144326