[libcxx-commits] [PATCH] D146366: [libc++] Use the stdlib=<LIB> Lit feature instead of use_system_cxx_lib

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 28 06:20:34 PDT 2023


ldionne added inline comments.


================
Comment at: libcxx/utils/ci/apple-install-libcxx.sh:114
+    # TODO: This shouldn't be necessary anymore if `clang -print-triple` behaved properly. Then LLVM would
+    #       guess the LLVM_DEFAULT_TARGET_TRIPLE properly and we wouldn't have to specify it.
+    target=$(xcrun clang -arch ${arch} -xc - -### 2>&1 | grep --only-matching -E '"-triple" ".+?"' | grep --only-matching -E '"[^ ]+-apple-[^ ]+?"' | tr -d '"')
----------------
Mordante wrote:
> Is there a LLVM or rdar bug report we can link to?
https://llvm.org/PR61762 I'll add it in the comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146366/new/

https://reviews.llvm.org/D146366



More information about the libcxx-commits mailing list