[libcxx-commits] [PATCH] D146421: [release/16.x][libc++] Revert the bitset sort optimization

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Mar 27 12:37:17 PDT 2023


ldionne added subscribers: thieta, tstellar.
ldionne added a comment.

@tstellar @thieta This patch is a bit special -- it is done on top of `release/16.x` directly so I wouldn't go through the usual cherry-picking process. Once it is reviewed, should I wait for your approval to land it manually on `release/16.x`?

To summarize the situation, we noticed some issues after adopting a version of libc++ that included D122780 <https://reviews.llvm.org/D122780> and we took the decision to pull it out downstream until we can figure out how to handle this appropriately. After discussing it with some core libc++ contributors on Discord, we agreed that pulling it out of `release/16.x` was the best and safest way forward as well. We are not pulling it out of LLVM 17, instead we will find a way to handle the issue appropriately with a forward fix. But for LLVM 16, there's not enough time and we want to take the safest path forward.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146421/new/

https://reviews.llvm.org/D146421



More information about the libcxx-commits mailing list