[libcxx-commits] [PATCH] D146902: [libc++][spaceship[NFC] P1614R2 `operator<=>` moves misplaced tests to correct location
Hristo Hristov via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Mar 27 03:12:31 PDT 2023
H-G-Hristov added a comment.
In D146902#4223450 <https://reviews.llvm.org/D146902#4223450>, @philnik wrote:
> Please mention in the commit message that you also update the status page.
Thank you for the review!
I am not entirely sure about what to do about the commit message exactly. I have already mentioned the text bellow in one of my commits on my branch and also updated the summary above. Is there anything else I need to do. Wouldn't that text be included in the commit message during `arc land`-ing it:
> [libc++][spaceship[NFC] P1612R2 `operator<=>` moves misplaced tests to correct location
>
> - Moved misplaced tests from `libcxx/test/libcxx` to `libcxx/test/std`
> - Updated `operator<=>` implementation status
>
> Related docs:
>
> - https://eel.is/c++draft/
> - https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1614r2.html
>
> Differential Revision: https://reviews.llvm.org/D146902
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146902/new/
https://reviews.llvm.org/D146902
More information about the libcxx-commits
mailing list