[libcxx-commits] [PATCH] D146902: [libc++][spaceship[NFC] P1612R2 `operator<=>` moves misplaced tests to correct location

[Hristo Hristov via Phabricator via libcxx-commits]

H-G-Hristov created this revision.
Herald added a subscriber: yaxunl.
Herald added a project: All.
H-G-Hristov edited the summary of this revision.
H-G-Hristov updated this revision to Diff 508488.
H-G-Hristov added a comment.
H-G-Hristov updated this revision to Diff 508500.
H-G-Hristov published this revision for review.
H-G-Hristov added a subscriber: philnik.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Run CI


H-G-Hristov added a comment.

Rebased


H-G-Hristov added a comment.

@philnik Could you please review this patch?



================
Comment at: libcxx/docs/Status/SpaceshipProjects.csv:34-35
 | `[charconv.syn] <https://wg21.link/charconv.syn>`_,| `from_chars_result <https://reviews.llvm.org/D112366>`_,None,Mark de Wever,|Complete|
-| `[stacktrace.entry.cmp] <https://wg21.link/stacktrace.entry.cmp>`_,| stacktrace_entry,None,Unassigned,|Not Started|
-| `[stacktrace.basic.cmp] <https://wg21.link/stacktrace.basic.cmp>`_,| basic_stacktrace,[alg.three.way],Unassigned,|Not Started|
+| `[stacktrace.entry.cmp] <https://wg21.link/stacktrace.entry.cmp>`_,| `stacktrace_entry <https://reviews.llvm.org/D123228>`_,None,Nikolas Klauser,|In Progress|
+| `[stacktrace.basic.cmp] <https://wg21.link/stacktrace.basic.cmp>`_,| `basic_stacktrace <https://reviews.llvm.org/D123228>`_,[alg.three.way],Nikolas Klauser,|In Progress|
 | `[string.cmp] <https://wg21.link/string.cmp>`_,| `basic_string <https://reviews.llvm.org/D131421>`_,None,Mark de Wever,|Complete|
----------------
These are not part of P1614R2. Should I just remove them?


P1614R2:

- Moved misplaced tests from `libcxx/test/libcxx` to `libcxx/test/std`
- Updated `operator<=>` implementation status

Related docs:

- https://eel.is/c++draft/
- https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1614r2.html


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D146902

Files:
  libcxx/docs/Status/SpaceshipProjects.csv
  libcxx/test/libcxx/containers/associative/map/compare.three_way.pass.cpp
  libcxx/test/libcxx/containers/associative/multimap/compare.three_way.pass.cpp
  libcxx/test/libcxx/containers/sequences/deque/compare.three_way.pass.cpp
  libcxx/test/libcxx/containers/sequences/forwardlist/compare.three_way.pass.cpp
  libcxx/test/std/containers/associative/map/compare.three_way.pass.cpp
  libcxx/test/std/containers/associative/multimap/compare.three_way.pass.cpp
  libcxx/test/std/containers/sequences/deque/compare.three_way.pass.cpp
  libcxx/test/std/containers/sequences/forwardlist/compare.three_way.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146902.508500.patch
Type: text/x-patch
Size: 10712 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230327/64385208/attachment.bin>