[libcxx-commits] [PATCH] D146398: [libcxx] Fix using std::wcout/wcin on Windows with streams configured in wide mode

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D146398#4221400 <https://reviews.llvm.org/D146398#4221400>, @fsb4000 wrote:

> Sorry, I didn't have time on the weekdays. But I have time today.
>
> Yes, it looks good.

Thanks for having a look!

> I restarted CI but it seems it doesn't work currently...

Yeah... The remaining failures from before were unrelated to this patch anyway.

> By the way how should I apply the patch locally?
>
> I tried this way:
>
> 1. Save file https://reviews.llvm.org/file/data/4ebdk4eqonefejv45365/PHID-FILE-kpusoqwct45nr6shhmdk/D146398.diff
>
> 2. git checkout f721fcb <https://reviews.llvm.org/rGf721fcb6ed0a186b8f146282467dd8420a5a36d0>
>
> 3. git apply D146398 <https://reviews.llvm.org/D146398>.diff
>
> But I got an error that git couldn't apply. So I just manually copy-pasted the changes locally.

That's weird - I tried those exact steps, and it succeeded for me. If `git apply` is too fussy, I'd try with `patch -p1 < D146398.diff` too (after clearing up any potential intermediate state from a previous failed application of the patch).

The easiest way generally is if you have the `arc` tool available (and patched to work with newer versions of PHP, if you happen to have that) - then you can do just `arc patch --nobranch D146398` to have it download and apply the patch in the current branch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146398/new/

https://reviews.llvm.org/D146398