[libcxx-commits] [PATCH] D146675: [libc++] Warn on including headers that are deprecated in C++17

[Alan Zhao via Phabricator via libcxx-commits]

ayzhao added a comment.

In D146675#4219987 <https://reviews.llvm.org/D146675#4219987>, @Mordante wrote:

> I have not looked closely at the patch, can you please add the paper number in the summary and update the status page
> `libcxx/doc/Status`? That makes reviewing the changes a lot easier.

The headers were marked deprecated in p0063r3 <https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0063r3.html>, which, interestingly enough, is already marked complete in the status page <https://github.com/llvm/llvm-project/blob/f23ea4cbd443601a0d6666a5fae6558243051348/libcxx/docs/Status/Cxx17Papers.csv#L46>.



================
Comment at: libcxx/test/std/language.support/support.runtime/cstdbool.pass.cpp:11
 
+// REQUIRES: c++11 || c++0x || c++14 || c++1y
+// XFAIL: c++17
----------------
Mordante wrote:
> Why not using the UNSUPPORTED like we usually do?
My idea was that by using `XFAIL`, we can test that the deprecation warning works (since we build with `-Werror`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146675/new/

https://reviews.llvm.org/D146675