[libcxx-commits] [PATCH] D146682: [libcxx] Fix build bustage with threads disabled

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 23 05:34:05 PDT 2023


philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

I see the problem now. The `#ifdef _LIBCPP_HAS_NO_THREADS` is split in the middle of the file, which results in a function being defined in the global namespace instead of the standard one. LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146682/new/

https://reviews.llvm.org/D146682



More information about the libcxx-commits mailing list