[libcxx-commits] [PATCH] D144822: [libc++][ranges] P2711R1 Making multi-param constructors of views explicit
Hristo Hristov via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Mar 23 00:44:27 PDT 2023
H-G-Hristov added a comment.
@philnik @Mordante
Thank you for the reviews!
I'd like to confirm what would be appropriate course of action on my side at this point in general:
1. I believe I addressed all remarks (IMO).
2. I fixed all related CI errors but there is still one unrelated (IMO).
3. I got LGTM but I still made changes after that.
In the context of the above at this point:
1. Shall I request a re-review explicitly.
2. Shall I wait for another review.
3. Shall I decide on my own if I am good to land the patch or wait for 1) or 2)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144822/new/
https://reviews.llvm.org/D144822
More information about the libcxx-commits
mailing list