[libcxx-commits] [PATCH] D136765: [ASan][libcxx] Annotating std::vector with all allocators

Tue Mar 21 23:23:26 PDT 2023

AdvenamTacet added a comment.

I was thinking about a solution for the silent error.

API for contiguous containers was extended on Oct 28 2022, - rGdd1b7b797a116eed588fd752fbe61d34deeb24e4 <https://reviews.llvm.org/rGdd1b7b797a116eed588fd752fbe61d34deeb24e4>.

API for double ended containers was commited on Nov 22 2022 - rG1c5ad6d2c01294a0decde43a88e9c27d7437d157 <https://reviews.llvm.org/rG1c5ad6d2c01294a0decde43a88e9c27d7437d157>.
And extended on Nov 29  - rGe1657e322902d973aea606d3557f938ce0e0f06c <https://reviews.llvm.org/rGe1657e322902d973aea606d3557f938ce0e0f06c>

If we first land D132092 <https://reviews.llvm.org/D132092> (annotations for std::deque with default allocator only), there will be no silent error, as a missing function in `compiler-rt` causes an error.

That solutions holds water only if D132092 <https://reviews.llvm.org/D132092> will be accepted, but I hope it will be. The pach is ready for review.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136765/new/

https://reviews.llvm.org/D136765