[libcxx-commits] [PATCH] D144822: [libc++][ranges] P2711R1 Making multi-param constructors of views explicit

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Note I just skimmed over the patch out of curiosity and I didn't do a real review. I noticed some issues.



================
Comment at: libcxx/docs/Status/Cxx2b.rst:46
    .. [#note-P2520R0] P2520R0: Libc++ implemented this paper as a DR in C++20 as well.
+   .. [#note-P2711R1] P2711R1: ``join_with_view`` hasn't been done yet since this types isn't implemented yet.
 
----------------



================
Comment at: libcxx/test/std/ranges/range.adaptors/range.drop.while/ctor.view.pass.cpp:38
+
+#if _LIBCPP_STD_VER >= 23
+
----------------
We shouldn't use `_LIBCPP_foo` macros in our test suite. Other vendors like MSVC STL and libstdc++ use our tests too. They don't define `_LIBCPP_foo` macros.

Note this change requires `#include "test_macros.h"` too.

The same applies to the other tests for `explicit`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144822/new/

https://reviews.llvm.org/D144822