[libcxx-commits] [PATCH] D145881: [libc++][spaceship] Implement `operator<=>` for `duration`

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D145881#4210510 <https://reviews.llvm.org/D145881#4210510>, @H-G-Hristov wrote:

> In D145881#4210481 <https://reviews.llvm.org/D145881#4210481>, @Mordante wrote:
>
>> In D145881#4210457 <https://reviews.llvm.org/D145881#4210457>, @H-G-Hristov wrote:
>>
>>> Rebased
>>
>> Nice I see committing work!
>>
>> FYI `arc land` will automatically rebase for you. There is no need to update the review with these changes.
>
> Thank you very much!
>
> I got two error messages one after another. So I thought that I needed to rebase to fix them:

<snip>

> Only after the second rebase and `arc diff --update`-ing twice the `arc land` completed successfuly.
>
> Maybe I did something wrong. I hope that it's not a problem.

This happens sometimes, the `arc land` operation is not atomic. For example

- you fetch the commits
- somebody else lands their patch
- you rebase
- now your push fails

I normally just do `arc land` a second time, and occasionally a third time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145881/new/

https://reviews.llvm.org/D145881