[libcxx-commits] [PATCH] D144822: [libc++][ranges] P2711R1 Making multi-param constructors of views explicit

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

LGTM % nits.



================
Comment at: libcxx/include/__config:874-878
+#  if _LIBCPP_STD_VER >= 23
+#    define _LIBCPP_EXPLICIT_SINCE_CXX23 explicit
+#  else
+#    define _LIBCPP_EXPLICIT_SINCE_CXX23
+#  endif
----------------
Please move this up to the `_LIBCPP_EXPLICIT_SINCE_CXX14`.


================
Comment at: libcxx/include/__ranges/filter_view.h:67
 
-    _LIBCPP_HIDE_FROM_ABI
-    constexpr filter_view(_View __base, _Pred __pred)
-      : __base_(std::move(__base)), __pred_(in_place, std::move(__pred))
-    { }
+    _LIBCPP_HIDE_FROM_ABI 
+    constexpr _LIBCPP_EXPLICIT_SINCE_CXX23 filter_view(_View __base, _Pred __pred)
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144822/new/

https://reviews.llvm.org/D144822