[libcxx-commits] [PATCH] D145881: [libc++][spaceship] Implement `operator<=>` for `duration`

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 21 09:18:23 PDT 2023


Mordante added a comment.

In D145881#4207179 <https://reviews.llvm.org/D145881#4207179>, @H-G-Hristov wrote:

> In D145881#4204872 <https://reviews.llvm.org/D145881#4204872>, @Mordante wrote:
>
>> Thanks! LGTM! IIRC you have commit access right?
>
> Thank you for the review!
>
> I should have commit access now but it will be my first attempt.
>
> I've setup SSH keys with my GitHub account.
> Would that be the right procedure:
>
>> $ cd llvm-project
>> $ git checkout P1614R2-spaceship-operator-duration
>> $ arc land
>
> This page describes a git based approach https://llvm.org/docs/Contributing.html
>
> The CI failures appear unrelated. Shall I try to commit now?

If you created the review you can indeed use arc land. Feel free to commit the change!

If you run into issues best visit Discord, there we're faster to respond.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145881/new/

https://reviews.llvm.org/D145881



More information about the libcxx-commits mailing list