[libcxx-commits] [PATCH] D146088: [libc++] Qualifies size_t.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D146088#4207431 <https://reviews.llvm.org/D146088#4207431>, @EricWF wrote:

> So we've changed a bunch of tests here. Do we have a plan for making these tests actually run with true-modules as well as with include?
> (This shouldn't block this change, but I want to know where we're headed).

We indeed want to run them with true modules. This should also prevent regressions where `::size_t` will be reintroduced in the test suite. (Without regression test it will be a matter of time.)
We have not yet decided on an exact plan yet. I have a script (https://reviews.llvm.org/D144994#change-Wk5BJhOsPqr9) that can convert our current tests to use imports. Some people are not happy with committing the result in tree, for now the script is intended be used in the CI to convert the tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146088/new/

https://reviews.llvm.org/D146088