[libcxx-commits] [PATCH] D146214: [ASan][libc++] Annotating std::basic_string with all allocators

Tacet via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Mar 20 12:53:47 PDT 2023


AdvenamTacet added inline comments.


================
Comment at: libcxx/test/libcxx/containers/strings/no_asan.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
EricWF wrote:
> It's not clear to me what this test is supposed to do.
> 
> Does the name mean it should only run without address sanitizer?
Maybe I should change the name, but I added a description. If you have any suggestion, please let me know. This test turns off annotations for a specific allocator.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146214/new/

https://reviews.llvm.org/D146214



More information about the libcxx-commits mailing list