[libcxx-commits] [PATCH] D146372: [libc++]Enforce `-Wzero-as-null-pointer-constant`

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks for working on this!

In D146372#4204837 <https://reviews.llvm.org/D146372#4204837>, @philnik wrote:

> These are a lot more changes then expected. Let's split this up into multiple patches. I would suggest that we first enable the warning inside the clang-tidy test to check our headers and then enable the warning inside the tests. As a third patch we can then change the three way comparison.

+1 for splitting the patch especially since the changes fail in the CI.



================
Comment at: libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/int.pass.cpp:50
     {
-        std::istream is((std::streambuf*)0);
+        std::istream is((std::streambuf*)nullptr);
         int n = 0;
----------------
Doesn't this work too?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146372/new/

https://reviews.llvm.org/D146372