[libcxx-commits] [PATCH] D145587: [libc++] Remove symbols for a std::allocator_arg & friends from the dylib

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

In D145587#4204717 <https://reviews.llvm.org/D145587#4204717>, @ldionne wrote:

> In D145587#4178814 <https://reviews.llvm.org/D145587#4178814>, @Mordante wrote:
>
>> It would still be possible if we make this an extra library, which uses can link to manually, or automatically when invoking clang with `std=c++98 -stdlib=libc++`. (In a similar fashion we do for the experimental library.)
>>
>> Note that is something we can do, I'm not convinced we should.
>
> Yeah, I agree. For the time being, since I think there won't be actual impact to this change, I would be tempted to go ahead. In the past we've had some success at making these sorts of benign ABI breaks when we did our due diligence to check that nobody would be broken. Here I feel like it's within the acceptable margin of error -- I would be genuinely surprised if someone was actually relying on that due to the explanations in the patch, so I am tempted to keep things simple and just go with it. Also, we are pretty early in the LLVM 17 release cycle so if this breaks a project really badly, we should have plenty of time to make changes.

Since this is an ABI break, let's inform the vendors about this change. If this is an issue for other vendors we can consider a C++03 library. For now I'm fine to go ahead with the breakage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145587/new/

https://reviews.llvm.org/D145587