[libcxx-commits] [PATCH] D146366: [libc++] Use the stdlib=<LIB> Lit feature instead of use_system_cxx_lib

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.

Thanks, I really like this patch! LGTM when the CI passes,



================
Comment at: libcxx/utils/ci/apple-install-libcxx.sh:114
+    # TODO: This shouldn't be necessary anymore if `clang -print-triple` behaved properly. Then LLVM would
+    #       guess the LLVM_DEFAULT_TARGET_TRIPLE properly and we wouldn't have to specify it.
+    target=$(xcrun clang -arch ${arch} -xc - -### 2>&1 | grep --only-matching -E '"-triple" ".+?"' | grep --only-matching -E '"[^ ]+-apple-[^ ]+?"' | tr -d '"')
----------------
Is there a LLVM or rdar bug report we can link to?


================
Comment at: libcxx/utils/libcxx/test/features.py:339
   Feature(name='availability-fp_to_chars-missing',
-    when=lambda cfg: BooleanExpression.evaluate('use_system_cxx_lib && target={{.+}}-apple-macosx{{(10.9|10.10|10.11|10.12|10.13|10.14|10.15|11.0)(.0)?}}', cfg.available_features)),
+    when=lambda cfg: BooleanExpression.evaluate('stdlib=apple-libc++ && target={{.+}}-apple-macosx{{(10.9|10.10|10.11|10.12|10.13|10.14|10.15|11.0|12.0|13.0)(.0)?}}', cfg.available_features)),
 
----------------
I see this modifies the same line again, but this time I agree with a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146366/new/

https://reviews.llvm.org/D146366