[libcxx-commits] [PATCH] D146379: [libc++] These throwing allocation functions shouldn't return null.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a subscriber: ldionne.
Mordante added a comment.

Thanks for the quick fix. I just saw on Discord @ldionne wants to look into this further.



================
Comment at: libcxxabi/src/stdlib_new_delete.cpp:43
 #else
-            break;
+            std::__libcpp_unreachable();
 #endif
----------------
I really dislike `std::__libcpp_unreachable` since it just results in undefined behaviour. Either we should do nothing or `assert(false);`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146379/new/

https://reviews.llvm.org/D146379