[libcxx-commits] [PATCH] D146384: [libc++] Change linkage for some functions.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante created this revision.
Herald added a subscriber: mikhail.ramalho.
Herald added a project: All.
Mordante requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Internal linkages fails when building libc++ with modules. Using
internal linkage is headers seems questionable to change the linkage.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D146384

Files:
  libcxx/include/__algorithm/ranges_find_if.h
  libcxx/include/__algorithm/ranges_min_element.h


Index: libcxx/include/__algorithm/ranges_min_element.h
===================================================================
--- libcxx/include/__algorithm/ranges_min_element.h
+++ libcxx/include/__algorithm/ranges_min_element.h
@@ -32,7 +32,7 @@
 
 // TODO(ranges): `ranges::min_element` can now simply delegate to `std::__min_element`.
 template <class _Ip, class _Sp, class _Proj, class _Comp>
-_LIBCPP_HIDE_FROM_ABI static constexpr
+_LIBCPP_HIDE_FROM_ABI constexpr
 _Ip __min_element_impl(_Ip __first, _Sp __last, _Comp& __comp, _Proj& __proj) {
   if (__first == __last)
     return __first;
Index: libcxx/include/__algorithm/ranges_find_if.h
===================================================================
--- libcxx/include/__algorithm/ranges_find_if.h
+++ libcxx/include/__algorithm/ranges_find_if.h
@@ -31,7 +31,7 @@
 namespace ranges {
 
 template <class _Ip, class _Sp, class _Pred, class _Proj>
-_LIBCPP_HIDE_FROM_ABI static constexpr
+_LIBCPP_HIDE_FROM_ABI constexpr
 _Ip __find_if_impl(_Ip __first, _Sp __last, _Pred& __pred, _Proj& __proj) {
   for (; __first != __last; ++__first) {
     if (std::invoke(__pred, std::invoke(__proj, *__first)))


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146384.506405.patch
Type: text/x-patch
Size: 1163 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230319/8e7c83ca/attachment.bin>