[libcxx-commits] [PATCH] D146378: [runtimes] Don't use -Wall on clang-cl builds

[Nikolas Klauser via Phabricator via libcxx-commits]

This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe6cc0faa7382: [runtimes] Don't use -Wall on clang-cl builds (authored by philnik).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146378/new/

https://reviews.llvm.org/D146378

Files:
  runtimes/cmake/Modules/WarningFlags.cmake


Index: runtimes/cmake/Modules/WarningFlags.cmake
===================================================================
--- runtimes/cmake/Modules/WarningFlags.cmake
+++ runtimes/cmake/Modules/WarningFlags.cmake
@@ -12,7 +12,6 @@
   endif()
   # TODO: Should -Wconversion be enabled?
   target_add_compile_flags_if_supported(${target} PRIVATE
-      -Wall
       -Wextra
       -Wnewline-eof
       -Wshadow


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146378.506381.patch
Type: text/x-patch
Size: 405 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230319/a79ee2bd/attachment.bin>