[libcxx-commits] [PATCH] D146378: [runtimes] Disable -Wreserved-identitifer on clang-cl builds

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik created this revision.
Herald added a project: All.
philnik requested review of this revision.
Herald added projects: libc++, libc++abi.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.
Herald added a reviewer: libc++abi.

It looks like `-Wreserved-identifier` is enabled in clang-cl configurations for some reason. This disables it explicitly to fix the windows builds.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D146378

Files:
  runtimes/cmake/Modules/WarningFlags.cmake


Index: runtimes/cmake/Modules/WarningFlags.cmake
===================================================================
--- runtimes/cmake/Modules/WarningFlags.cmake
+++ runtimes/cmake/Modules/WarningFlags.cmake
@@ -48,6 +48,7 @@
         -Wno-deprecated # FIXME: Remove this and fix all occurrences.
         -Wno-shift-sign-overflow # FIXME: Why do we need this with clang-cl but not clang?
         -Wno-double-promotion # FIXME: remove me
+        -Wno-reserved-identifier
       )
     endif()
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146378.506363.patch
Type: text/x-patch
Size: 498 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230319/dfa36b0c/attachment.bin>