[libcxx-commits] [PATCH] D146361: [libc++][Apple] Make sure to set the LIBCXX_LIBRARY_VERSION when building for Apple

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Mar 18 09:10:45 PDT 2023


ldionne created this revision.
Herald added subscribers: mikhail.ramalho, arichardson.
Herald added a project: All.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D146361

Files:
  libcxx/utils/ci/apple-install-libcxx.sh


Index: libcxx/utils/ci/apple-install-libcxx.sh
===================================================================
--- libcxx/utils/ci/apple-install-libcxx.sh
+++ libcxx/utils/ci/apple-install-libcxx.sh
@@ -119,7 +119,8 @@
                 -DCMAKE_INSTALL_PREFIX="${build_dir}/${arch}-install" \
                 -DCMAKE_INSTALL_NAME_DIR="/usr/lib" \
                 -DCMAKE_OSX_ARCHITECTURES="${arch}" \
-                -DLIBCXXABI_LIBRARY_VERSION="${version}"
+                -DLIBCXXABI_LIBRARY_VERSION="${version}" \
+                -DLIBCXX_LIBRARY_VERSION="${version}"
 
     if [ "$headers_only" = true ]; then
         xcrun cmake --build "${build_dir}/${arch}" --target install-cxx-headers install-cxxabi-headers -- -v


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146361.506300.patch
Type: text/x-patch
Size: 732 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230318/ce755c86/attachment.bin>


More information about the libcxx-commits mailing list