[libcxx-commits] [PATCH] D146360: [libc++][Apple] Make sure we install libc++experimental.a

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Mar 18 08:57:41 PDT 2023


ldionne created this revision.
Herald added subscribers: mikhail.ramalho, arichardson.
Herald added a project: All.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D146360

Files:
  libcxx/test/libcxx/vendor/apple/system-install-properties.sh.cpp
  libcxx/utils/ci/apple-install-libcxx.sh


Index: libcxx/utils/ci/apple-install-libcxx.sh
===================================================================
--- libcxx/utils/ci/apple-install-libcxx.sh
+++ libcxx/utils/ci/apple-install-libcxx.sh
@@ -150,6 +150,9 @@
     universal_dylib libc++.1.dylib
     universal_dylib libc++abi.dylib
     (cd "${install_dir}/usr/lib" && ln -s "libc++.1.dylib" libc++.dylib)
+
+    experimental_libs=$(for arch in ${architectures}; do echo "${build_dir}/${arch}-install/lib/libc++experimental.a"; done)
+    xcrun lipo -create ${experimental_libs} -output "${install_dir}/usr/lib/libc++experimental.a"
 fi
 
 # Install the headers by copying the headers from one of the built architectures
Index: libcxx/test/libcxx/vendor/apple/system-install-properties.sh.cpp
===================================================================
--- libcxx/test/libcxx/vendor/apple/system-install-properties.sh.cpp
+++ libcxx/test/libcxx/vendor/apple/system-install-properties.sh.cpp
@@ -41,3 +41,7 @@
 // when they are loaded by dyld, if the compatibility version was bumped.
 //
 // RUN: otool -L "%{lib}/libc++.1.dylib" | grep "libc++.1.dylib" | grep "compatibility version 1.0.0"
+
+// Make sure we install libc++experimental.a in the right location.
+//
+// RUN: stat "%{lib}/libc++experimental.a"


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146360.506297.patch
Type: text/x-patch
Size: 1282 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230318/065503c6/attachment.bin>


More information about the libcxx-commits mailing list