[libcxx-commits] [PATCH] D145847: [libc++][format] Implements LWG3892.

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF accepted this revision as: EricWF.
EricWF added a comment.
Herald added a subscriber: mikhail.ramalho.

Nice tests. Big fan of the work done in this patch.

I haven't reviewed it for correctness w.r.t. the format spec, but in general I think it looks good.



================
Comment at: libcxx/include/__format/range_formatter.h:265
+    __parse_ctx.advance_to(__begin);
+    [[maybe_unused]] typename _ParseContext::iterator __result = __underlying_.parse(__parse_ctx);
+    _LIBCPP_ASSERT(__result == __begin,
----------------
Is there a reason for always doing this rather than just guarding it in a macro?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145847/new/

https://reviews.llvm.org/D145847